fix: fix and cleanup metrics (sequencers + block)

CHANGELOG.md

@@ -36,6 +36,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - **BREAKING:** Removed `evnode.v1.HealthService` gRPC endpoint. Use HTTP endpoints: `GET /health/live` and `GET /health/ready`. ([#2800](https://github.com/evstack/ev-node/pull/2800))
 - **BREAKING:** Removed `TrustedHash` configuration option and `--evnode.node.trusted_hash` flag. Sync service now automatically determines starting height from local store state ([#2838](https://github.com/evstack/ev-node/pull/2838))
+- **BREAKING:** Removed unused and confusing metrics from sequencers and block processing, including sequencer-specific metrics (gas price, blob size, transaction status, pending blocks), channel buffer metrics, overly granular error metrics, block production categorization metrics, and sync lag metrics. Essential metrics for DA submission health, block production, and performance monitoring are retained. [#2904](https://github.com/evstack/ev-node/pull/2904)
 
 ### Fixed
 

apps/evm/cmd/run.go

@@ -111,19 +111,13 @@ func createSequencer(
 	nodeConfig config.Config,
 	genesis genesis.Genesis,
 ) (coresequencer.Sequencer, error) {
-	singleMetrics, err := single.NopMetrics()
-	if err != nil {
-		return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
-	}
-
 	sequencer, err := single.NewSequencer(
 		ctx,
 		logger,
 		datastore,
 		da,
 		[]byte(genesis.ChainID),
 		nodeConfig.Node.BlockTime.Duration,
-		singleMetrics,
 		nodeConfig.Node.Aggregator,
 	)
 	if err != nil {

apps/grpc/cmd/run.go

@@ -119,19 +119,13 @@ func createSequencer(
 	nodeConfig config.Config,
 	genesis genesis.Genesis,
 ) (coresequencer.Sequencer, error) {
-	singleMetrics, err := single.NopMetrics()
-	if err != nil {
-		return nil, fmt.Errorf("failed to create single sequencer metrics: %w", err)
-	}
-
 	sequencer, err := single.NewSequencer(
 		ctx,
 		logger,
 		datastore,
 		da,
 		[]byte(genesis.ChainID),
 		nodeConfig.Node.BlockTime.Duration,
-		singleMetrics,
 		nodeConfig.Node.Aggregator,
 	)
 	if err != nil {

apps/testapp/cmd/run.go

@@ -68,11 +68,6 @@ var RunCmd = &cobra.Command{
 			return err
 		}
 
-		singleMetrics, err := single.NopMetrics()
-		if err != nil {
-			return err
-		}
-
 		// Start the KV executor HTTP server
 		if kvEndpoint != "" { // Only start if endpoint is provided
 			httpServer := kvexecutor.NewHTTPServer(executor, kvEndpoint)
@@ -101,7 +96,6 @@ var RunCmd = &cobra.Command{
 			&daJrpc.DA,
 			[]byte(genesis.ChainID),
 			nodeConfig.Node.BlockTime.Duration,
-			singleMetrics,
 			nodeConfig.Node.Aggregator,
 		)
 		if err != nil {