refactor(server): improve rollback cmd

[julienrbrt]

Overview

Same as evstack/ev-node#2744 for ev-abci.
Blocked on evstack/ev-node#2744 for ev-node changes.

[gemini-code-assist]

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the server's rollback command by removing the --skip-p2p-stores flag, making P2P store rollback a default action. It also enhances error handling for these operations and updates numerous Go dependencies.

Highlights

• Intent: This pull request aims to refactor and improve the rollback command within the server. The primary goal is to streamline the rollback process, particularly concerning P2P-related stores, and enhance error handling.
• Key Changes: The rollback command (server/rollback_cmd.go) has been updated to remove the --skip-p2p-stores flag, making the rollback of goheaderstore and data sync service state a default behavior when applicable. Error handling for these rollback operations has been improved by using errors.Join to aggregate potential errors, ensuring both header and data store rollbacks are attempted. The success message logic has also been simplified and integrated directly into the command execution.
• Dependency Updates: This PR includes several dependency updates in go.mod and go.sum. Notable updates include: an upgrade of github.com/celestiaorg/go-header to a newer version from the author's fork (github.com/julienrbrt/go-header), an update to github.com/evstack/ev-node to v1.0.0-beta.6.0.20251008143743-d65867e98e74, and various updates to indirect dependencies such as go-square/v3, ipfs/boxo, go-log/v2, libp2p related modules, opentelemetry components, golang.org/x modules (e.g., exp, mod, telemetry, tools), and google.golang.org/grpc/protobuf.
• Reviewer Notes: Reviewers should focus on the removal of the skipP2PStores flag and its implications, ensuring that the default rollback behavior for P2P stores is desired. Additionally, verify the improved error handling with errors.Join and the updated dependency versions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the rollback command, primarily by updating dependencies and simplifying the command's logic. My review focuses on the changes in server/rollback_cmd.go.

I've identified a critical issue where rollback errors are silently ignored, which could lead to an inconsistent state. I've also noted a behavioral change in the user-facing instructions that might be unintentional. I've provided a single comprehensive comment with a suggested fix for both issues to maintain code correctness and clarity.

[chatton]

LGTM