-
Notifications
You must be signed in to change notification settings - Fork 4
refactor(server): bump go-header and use DeleteRange api #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the server's rollback command to utilize a new API (DeleteFromHead) from the go-header library. This change improves the way header and data store states are managed during rollbacks. To facilitate this, the go-header dependency is temporarily pointed to a local development version.
Highlights
- Dependency Update: The
go-headerdependency has been updated to use a local path (/home/julien/downloads/go-header). This change is likely for local development or testing purposes to utilize a specific version of thego-headerlibrary that is not yet officially released or available via standard Go module proxies. - API Usage Refactor: The
server/rollback_cmd.gofile has been refactored to replace calls toDeleteTowith the newDeleteFromHeadAPI for bothheaderStoreanddataStore. This updates the rollback mechanism to align with the new API provided by thego-headerlibrary.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the rollback command to use the DeleteFromHead API from go-header and updates the dependency. The logic change in server/rollback_cmd.go appears correct and aligns with the goal of rolling back state. However, a critical issue exists in go.mod where a replace directive points to a local file path. This must be corrected to ensure the project is buildable in all environments.
|
This blocks ignite/apps#229. The tests will pass once this is merged. |
* chore: bump ev-node and ignite app * typo * go mod tidy * refactor(server): bump go-header and use DeleteFromHead api * updates * use fork * bump ev-node and sync rollback command * use tagged version * updates
Overview
Bump go-header. This fixes evstack/ev-node#2631 for ev-abci
Blocked on celestiaorg/go-header#347