Skip to content

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 9, 2025

Overview

Bump go-header. This fixes evstack/ev-node#2631 for ev-abci

Blocked on celestiaorg/go-header#347

@julienrbrt julienrbrt requested a review from a team as a code owner September 9, 2025 09:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the server's rollback command to utilize a new API (DeleteFromHead) from the go-header library. This change improves the way header and data store states are managed during rollbacks. To facilitate this, the go-header dependency is temporarily pointed to a local development version.

Highlights

  • Dependency Update: The go-header dependency has been updated to use a local path (/home/julien/downloads/go-header). This change is likely for local development or testing purposes to utilize a specific version of the go-header library that is not yet officially released or available via standard Go module proxies.
  • API Usage Refactor: The server/rollback_cmd.go file has been refactored to replace calls to DeleteTo with the new DeleteFromHead API for both headerStore and dataStore. This updates the rollback mechanism to align with the new API provided by the go-header library.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the rollback command to use the DeleteFromHead API from go-header and updates the dependency. The logic change in server/rollback_cmd.go appears correct and aligns with the goal of rolling back state. However, a critical issue exists in go.mod where a replace directive points to a local file path. This must be corrected to ensure the project is buildable in all environments.

@julienrbrt julienrbrt marked this pull request as draft September 9, 2025 09:12
Base automatically changed from julien/ingt to main September 9, 2025 14:11
@julienrbrt julienrbrt changed the title refactor(server): bump go-header and use DeleteFromHead api refactor(server): bump go-header and use DeleteRange api Sep 9, 2025
@julienrbrt julienrbrt marked this pull request as ready for review September 9, 2025 15:38
@julienrbrt
Copy link
Member Author

This blocks ignite/apps#229. The tests will pass once this is merged.
@randygrok could you review :)

@julienrbrt julienrbrt merged commit c80cc46 into main Sep 26, 2025
7 of 10 checks passed
@julienrbrt julienrbrt deleted the julien/rollback branch September 26, 2025 09:06
chatton pushed a commit that referenced this pull request Oct 7, 2025
* chore: bump ev-node and ignite app

* typo

* go mod tidy

* refactor(server): bump go-header and use DeleteFromHead api

* updates

* use fork

* bump ev-node and sync rollback command

* use tagged version

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix rollback go-header stores

3 participants