Refactor supported features

evosec · Jan 15, 2024 · a240bf2 · a240bf2
1 parent 13b1ec3
commit a240bf2
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/src/metabase/driver/firebird.clj b/src/metabase/driver/firebird.clj
@@ -258,22 +258,16 @@
     (sql.qp/->honeysql driver (t/local-date t))
     (hx/cast :TIMESTAMP (t/format "yyyy-MM-dd HH:mm:ss.SSSS" t))))
 
-(defmethod driver/database-supports? [:firebird :basic-aggregations]  [_ _] true)
-
-(defmethod driver/database-supports? [:firebird :expression-aggregations]  [_ _] true)
-
-(defmethod driver/database-supports? [:firebird :standard-deviation-aggregations]  [_ _] true)
-
-(defmethod driver/database-supports? [:firebird :foreign-keys]  [_ _] true)
-
-(defmethod driver/database-supports? [:firebird :nested-fields]  [_ _] false)
-
-(defmethod driver/database-supports? [:firebird :set-timezone]  [_ _] false)
-
-(defmethod driver/database-supports? [:firebird :nested-queries]  [_ _] true)
-
-(defmethod driver/database-supports? [:firebird :binning]  [_ _] false)
-
-(defmethod driver/database-supports? [:firebird :case-sensitivity-string-filter-options]  [_ _] false)
-
-(defmethod driver/database-supports? [:firebird :schemas]  [_ _] false)
+(doseq [[feature supported?] {; supported
+                              :basic-aggregations                      true
+                              :expression-aggregations                 true
+                              :foreign-keys                            true
+                              :nested-queries                          true
+                              :standard-deviation-aggregations         true
+                              ; not supported
+                              :binning                                 false
+                              :case-sensitivity-string-filter-options  false
+                              :nested-fields                           false
+                              :schemas                                 false
+                              :set-timezone                            false}]
+  (defmethod driver/database-supports? [:firebird feature] [_driver _feature _db] supported?))