Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file missing error on embroider when using custom rootURL #247

Conversation

sathish-pv
Copy link
Contributor

Using ember-svg-jar with custom rootURL in Embroider app, throws the below mentioned error and the chunk js and css are missing from final build.

Building into /private/var/folders/qt/rbrkt7wx48vggvxs2tcnzy70zb1g2b/T/embroider/270ee5
Environment: development
⠏ building... [@embroider/webpack]warning: in ./ember-svg-jar/index.html <script src="customrooturl/ember-svg-jar/static/js/2.ced0fc45.chunk.js"> does not exist on disk. If this is intentional, use a data-embroider-ignore attribute.
warning: in ./ember-svg-jar/index.html <script src="customrooturl/ember-svg-jar/static/js/main.0e7a56b1.chunk.js"> does not exist on disk. If this is intentional, use a data-embroider-ignore attribute.
warning: in ./ember-svg-jar/index.html  <link rel="stylesheet" href="customrooturl/ember-svg-jar/static/css/main.f3aef49e.chunk.css"> does not exist on disk. If this is intentional, use a data-embroider-ignore attribute.
assets by status 2.32 MiB [big]

@sathish-pv sathish-pv marked this pull request as ready for review December 29, 2022 07:10
@jherdman
Copy link
Collaborator

Are there any tests that could be added to help verify and document this change?

@sathish-pv
Copy link
Contributor Author

sathish-pv commented Jan 4, 2023

Are there any tests that could be added to help verify and document this change?

This can be tested by creating a development build and checking the static file index.html.

@evoactivity
Copy link
Owner

Hi @sathishpvns

Just checking in to see if this is still an issue for you? I have a few embroider apps and haven't noticed this issue.

Thanks

@sathish-pv
Copy link
Contributor Author

Hi, i still have the issue.
Can be reproduced with custom rootURL for svg-jar with deps
ember-svg-jar: 2.4.2
@embroider: 2.0.2

@evoactivity evoactivity merged commit 91824a3 into evoactivity:master Aug 1, 2023
@evoactivity
Copy link
Owner

This has been merged and released into 2.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants