Import asset viewer repo #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue I was having with Python
|
@rwwagner90 care to look this over? Next step will be leveraging Lerna/Nx to build this and copy it into public pre-publish |
jherdman
force-pushed
the
import-asset-viewer-repo
branch
from
8a8366a
to
2c02f17
Compare
|
@jherdman should we use pnpm perhaps? |
|
Probably. My understanding is that you ought to be using Ember CLI v4 first though. Is that accurate? |
I'm not sure. I didn't realize we were not on latest Ember / ember-cli. Perhaps we should update that stuff first? |
|
Yup! I spun up #241 for that work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial work to bring the asset-viewer code into the monorepo. Additional steps include leveraging Lerna/Nx to help with building an ember-svg-jar release.