-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type not found in strict mode #266
Labels
Comments
chancancode
added a commit
to chancancode/ember-svg-jar
that referenced
this issue
Mar 6, 2024
With a small change we should be able to make the types we already have apply to the `./helpers/svg-jar` module. Not addressed here: - The types claim the helper to be a class-based helper - Do we want people to be importing from `./helpers/svg-jar` or do we want a re-export - Do we want to restrict what can be imported via package.json's `exports` field ...etc Basically keeping things working as it is
Merged
evoactivity
pushed a commit
that referenced
this issue
Mar 6, 2024
With a small change we should be able to make the types we already have apply to the `./helpers/svg-jar` module. Not addressed here: - The types claim the helper to be a class-based helper - Do we want people to be importing from `./helpers/svg-jar` or do we want a re-export - Do we want to restrict what can be imported via package.json's `exports` field ...etc Basically keeping things working as it is
evoactivity
added a commit
that referenced
this issue
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to import the helper in a
.gts
file and I get the following error:I'm using embroider enabled app, with ember Stable TypeScript Types (using
import 'ember-source/types';
).Other than this error in VSCode, everything works correctly. Svg gets rendered correctly and there are no errors/warnings in app build.
The text was updated successfully, but these errors were encountered: