Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pnpm from test github action #577

Closed
roninjin10 opened this issue Oct 16, 2023 · 0 comments · Fixed by #576
Closed

Remove pnpm from test github action #577

roninjin10 opened this issue Oct 16, 2023 · 0 comments · Fixed by #576

Comments

@roninjin10
Copy link
Collaborator

In #512 we switched to bun but pnpm coverage broke. Pnpm test works great locally but the test coverage fails in CI. CI is using pnpm as a hack and is the only thing still using pnpm
@roninjin10 roninjin10 mentioned this issue Oct 16, 2023
Merged
1 task
roninjin10 added a commit that referenced this issue Oct 24, 2023
@roninjin10
⚡ chore(ci): Remove pnpm from test coverage action (#576)
a28ad33 
## Description

remove pnpm from test coverage ci action to speed up test action from 2
minutes to ___

Test coverage worked great locally but fails and misses test coverage in
ci

Closes #577

## Testing

Explain the quality checks that have been done on the code changes

## Additional Information

- [ ] I read the [contributing docs](../docs/contributing.md) (if this
is your first contribution)

Your ENS/address:

Co-authored-by: Will Cory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚡ chore(ci): Remove pnpm from test coverage action evmts/tevm-monorepo
1 participant
@roninjin10