Skip to content

Commit

Permalink
♻️ chore(bundler): Explicitly export public api (#587)
Browse files Browse the repository at this point in the history
## Description

Be explicit about the public api of bundler instead of `export * from
'./foo'`.

#586

## Testing

Explain the quality checks that have been done on the code changes

## Additional Information

- [ ] I read the [contributing docs](../docs/contributing.md) (if this
is your first contribution)

Your ENS/address:

Co-authored-by: Will Cory <[email protected]>
  • Loading branch information
roninjin10 and Will Cory authored Oct 16, 2023
1 parent 384429d commit 49549ef
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
2 changes: 1 addition & 1 deletion bundlers/bundler/src/createCache.d.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { SolcInputDescription, SolcOutput } from './solc/solc.js'
import type { Logger } from './types.js'

type CacheObject = {
export type CacheObject = {
[filePath: string]: SolcOutput
}

Expand Down
22 changes: 16 additions & 6 deletions bundlers/bundler/src/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/**
* ./types.ts
* @typedef {import('./types.js').AsyncBundlerResult} AsyncBundlerResult
* @typedef {import('./types.js').Bundler} Bundler
* @typedef {import('./types.js').BundlerResult} BundlerResult
Expand All @@ -8,10 +9,19 @@
* @typedef {import('./types.js').ModuleInfo} ModuleInfo
* @typedef {import('./types.js').SolidityResolver} SolidityResolver
* @typedef {import('./types.js').SyncBundlerResult} SyncBundlerResult
*
* ./createCache.js
* @typedef {import('./createCache.js').Cache} Cache
*/
export * from './solc/index.js'
export * from './unplugin.js'
export * from './bundler.js'
export * from './runtime/index.js'
export * from './utils/index.js'
export * from './createCache.js'
export { bundler } from './bundler.js'
export { createCache } from './createCache.js'
export { resolveArtifacts, resolveArtifactsSync } from './solc/index.js'
export {
vitePluginEvmts,
rollupPluginEvmts,
rspackPluginEvmts,
esbuildPluginEvmts,
webpackPluginEvmts,
} from './unplugin.js'
// export * from './runtime/index.js'
// export * from './utils/index.js'

1 comment on commit 49549ef

@vercel
Copy link

@vercel vercel bot commented on 49549ef Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment failed with the following error:

Resource is limited - try again in 1 hour (more than 100, code: "api-deployments-free-per-day").

Please sign in to comment.