Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

empty from for gas estimate [WIP] #212

Closed

Conversation

thomas-nguy
Copy link
Contributor

Closes: #201

Description

Allows empty from field when simulating transaction


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #212 (3ea09bf) into main (735f00d) will decrease coverage by 0.12%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   47.64%   47.51%   -0.13%     
==========================================
  Files          44       44              
  Lines        3031     3039       +8     
==========================================
  Hits         1444     1444              
- Misses       1508     1511       +3     
- Partials       79       84       +5     
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 0.00% <0.00%> (ø)
app/ante/eth.go 83.53% <9.09%> (-3.50%) ⬇️

Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/ante/eth.go Outdated Show resolved Hide resolved
x/evm/keeper/state_transition.go Show resolved Hide resolved
@thomas-nguy thomas-nguy force-pushed the thomas/201-allow-empty-from-field branch from 69f3f34 to 282f6d6 Compare July 8, 2021 07:40
@thomas-nguy thomas-nguy force-pushed the thomas/201-allow-empty-from-field branch from 464a4c6 to 3ea09bf Compare July 8, 2021 08:15
@fedekunze
Copy link
Contributor

is this PR still WIP?

@thomas-nguy
Copy link
Contributor Author

thomas-nguy commented Jul 8, 2021

Yes,

We need to be able to skip the "gas refund" in case of simulate in state_transition.go. I havent found a way to do it yet>
Maybe #236 might help

@fedekunze fedekunze marked this pull request as draft July 8, 2021 08:22
@yihuang
Copy link
Contributor

yihuang commented Jul 8, 2021

I think #236 fixes this empty from field issue, according to my test.

@thomas-nguy
Copy link
Contributor Author

Ok closing the PR as it will be fixed in #236

@thomas-nguy thomas-nguy closed this Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to call estimateGas without from field
4 participants