This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 563
empty from for gas estimate [WIP] #212
Closed
thomas-nguy
wants to merge
2
commits into
evmos:main
from
thomas-nguy:thomas/201-allow-empty-from-field
Closed
empty from for gas estimate [WIP] #212
thomas-nguy
wants to merge
2
commits into
evmos:main
from
thomas-nguy:thomas/201-allow-empty-from-field
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 47.64% 47.51% -0.13%
==========================================
Files 44 44
Lines 3031 3039 +8
==========================================
Hits 1444 1444
- Misses 1508 1511 +3
- Partials 79 84 +5
|
yihuang
reviewed
Jul 1, 2021
leejw51crypto
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fedekunze
reviewed
Jul 7, 2021
thomas-nguy
force-pushed
the
thomas/201-allow-empty-from-field
branch
from
July 8, 2021 07:40
69f3f34
to
282f6d6
Compare
thomas-nguy
force-pushed
the
thomas/201-allow-empty-from-field
branch
from
July 8, 2021 08:15
464a4c6
to
3ea09bf
Compare
is this PR still WIP? |
Yes, We need to be able to skip the "gas refund" in case of simulate in |
I think #236 fixes this empty from field issue, according to my test. |
Ok closing the PR as it will be fixed in #236 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #201
Description
Allows empty from field when simulating transaction
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)