Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

imp: remove distribution perms #1739

Merged
merged 2 commits into from
Apr 4, 2023
Merged

imp: remove distribution perms #1739

merged 2 commits into from
Apr 4, 2023

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Apr 4, 2023

Closes: #XXX

Description

Remove


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@facs95 facs95 requested a review from a team as a code owner April 4, 2023 12:48
@facs95 facs95 requested review from Vvaradinov and MalteHerrmann and removed request for a team April 4, 2023 12:48
@github-advanced-security
Copy link

You have successfully added a new Semgrep configuration .github/workflows/semgrep.yml:semgrep. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@facs95 facs95 merged commit 2814c78 into main Apr 4, 2023
@facs95 facs95 deleted the facs95/mod-perms branch April 4, 2023 14:32
@zsystm
Copy link

zsystm commented Apr 13, 2023

@facs95
Hi there.
I'm a little late, but I'd like to know why we needed this PR.

Any background or references on this would be appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants