Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Problem: feemarket's query cli has redundant height parameter #1230

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Aug 10, 2022

Description

Solution:

  • remove the positional height parameter, since there's a flag already.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

CHANGELOG.md Outdated Show resolved Hide resolved
Soluton:
- remove the positional height parameter, since there's a flag already.

Update CHANGELOG.md
@fedekunze fedekunze merged commit b3242ea into evmos:main Aug 10, 2022
@yihuang yihuang deleted the cli-height branch August 10, 2022 07:07
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants