Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Geth upgrade v1.10.19 #1159

Merged
merged 25 commits into from
Jul 8, 2022
Merged

Geth upgrade v1.10.19 #1159

merged 25 commits into from
Jul 8, 2022

Conversation

crypto-facs
Copy link
Contributor

Closes: #XXX

Description

The following changes were identified:

  • In RPC APIs where a block number can be given, you can now use "finalized" to refer to the latest finalized block. (#24282) → Update JSON-RPC
  • The EVM now implements EIP-3855 (PUSH0 instruction). This feature is not yet active in any fork. (#24039) → Update EnableEIPs
  • API change: debug_traceTransaction, in the default structured-logging mode, now returns the refund counter for every EVM execution step. (#24567)
  • eth/tracers: refactor traceTx to separate out struct logging 24326
  • MergeForkBlock renamed to MergeNetsplitBlock (#24904)

This last ones did not required any code changes as this endpoints are not yet supported on Ethermint:

  • some changes to debug_traceCall #24871

    • More info here
    • Will reject against pending blocks
    • Ability to override all evm-visible header fields.
    > debug.traceCall({from: eth.accounts[0], value:"0x1", gasPrice: "0xffffffff", gas: "0xffff", input: "0x43"}, "latest", {"blockoverrides":{"number": "0x50"}})
    
  • The new debug_getRawReceipts RPC method returns the binary representation of block receipts. (#24773)

  • The new debug_dbGet method can be used to read from the chain database. (#24739)

NOTE

Since EIPs were modified, this changed required a migration to Ethermint v3.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved
x/evm/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/evm/migrations/v3/migrate.go Outdated Show resolved Hide resolved
x/evm/migrations/v3/migrate.go Outdated Show resolved Hide resolved
x/evm/migrations/v3/types/chain_config.go Show resolved Hide resolved
x/evm/migrations/v3/types/chain_config.go Show resolved Hide resolved
x/evm/migrations/v3/types/chain_config.go Show resolved Hide resolved
x/evm/migrations/v3/migrate_test.go Show resolved Hide resolved
@fedekunze fedekunze requested a review from danburck June 29, 2022 17:19
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor change requested on the proto msgs. Any other rpc endpoints that were introduced?

proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved
proto/ethermint/evm/v1/evm.proto Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1159 (4b04f17) into main (31c3660) will decrease coverage by 0.21%.
The diff coverage is 66.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1159      +/-   ##
==========================================
- Coverage   61.76%   61.54%   -0.22%     
==========================================
  Files          90       91       +1     
  Lines        7312     7281      -31     
==========================================
- Hits         4516     4481      -35     
- Misses       2573     2577       +4     
  Partials      223      223              
Impacted Files Coverage Δ
x/evm/keeper/migrations.go 50.00% <0.00%> (-16.67%) ⬇️
x/evm/types/tracer.go 7.14% <0.00%> (-48.60%) ⬇️
x/evm/module.go 52.05% <50.00%> (-0.81%) ⬇️
x/evm/types/chain_config.go 93.28% <54.54%> (-2.03%) ⬇️
x/evm/migrations/v3/migrate.go 73.33% <73.33%> (ø)
x/evm/keeper/grpc_query.go 68.91% <75.67%> (-0.34%) ⬇️
rpc/types/block.go 50.46% <100.00%> (ø)
x/evm/keeper/state_transition.go 74.77% <100.00%> (ø)

Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a comment about the duplicated types in the migrations.

rpc/types/block.go Show resolved Hide resolved
x/evm/migrations/v3/types/params.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 8, 2022 10:52
@fedekunze fedekunze merged commit 4a6f4fd into evmos:main Jul 8, 2022
yihuang added a commit to yihuang/ethermint that referenced this pull request Jul 26, 2022
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
jbowen93 pushed a commit to celestiaorg/ethermint that referenced this pull request Jul 31, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to devon-chain/ethermint that referenced this pull request Aug 4, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
facs95 pushed a commit that referenced this pull request Aug 12, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Aug 15, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
@@ -21,3 +22,8 @@ func NewMigrator(keeper Keeper) Migrator {
func (m Migrator) Migrate1to2(ctx sdk.Context) error {
return v2.MigrateStore(ctx, &m.keeper.paramSpace)
}

// Migrate2to3 migrates the store from consensus version v2 to v3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Migrate2to3 migrates the store from consensus version v2 to v3
Is the comment misleading? why it says consensus version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module's version for state migration for consensus state machine.

devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
* upgrade geth and fix build

* add support for

* update EIPs

* fix keeper tests

* update traceTx function with latest geth changes

* remove unnecessary comments

* fix tests

* update proto

* add migrations

* update module version

* fix grpc test

* fix lint

* fix lint

* update changelog

* fix typo

* remove unnecessary format logs

* Update proto/ethermint/evm/v1/evm.proto

Co-authored-by: Federico Kunze Küllmer <[email protected]>

* remove debug true on default

* update comments

* fixing ante tests

* fixed cycle imports on migrate_test

* fix wrong naming

* update comment

Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants