Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

fix(evm): clear logs if tx failed in post processing hooks #1128

Merged
merged 3 commits into from
Jun 21, 2022
Merged

fix(evm): clear logs if tx failed in post processing hooks #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6899a7b
Problem: clear logs if tx failed in post processing hooks
yihuang Jun 15, 2022
fa3c93a
Update x/evm/keeper/state_transition.go
yihuang Jun 20, 2022
951fe60
Merge branch 'main' into main
fedekunze Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### State Machine Breaking

* (evm) [tharsis#1124](https://github.com/evmos/ethermint/pull/1124) Reject non-replay-protected tx in ante handler to prevent replay attack
* (evm) [\#1128](https://github.com/tharsis/ethermint/pull/1128) Clear tx logs if tx failed in post processing hooks
* (evm) [tharsis#1124](https://github.com/tharsis/ethermint/pull/1124) Reject non-replay-protected tx in `AnteHandler` to prevent replay attack

### API Breaking

Expand Down
1 change: 1 addition & 0 deletions x/evm/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ func (suite *EvmTestSuite) TestERC20TransferReverted() {

suite.Require().True(res.Failed())
suite.Require().Equal(tc.expErr, res.VmError)
suite.Require().Empty(res.Logs)

after := k.GetBalance(suite.ctx, suite.from)

Expand Down
3 changes: 3 additions & 0 deletions x/evm/keeper/state_transition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,9 @@ func (k *Keeper) ApplyTransaction(ctx sdk.Context, tx *ethtypes.Transaction) (*t
// If hooks return error, revert the whole tx.
res.VmError = types.ErrPostTxProcessing.Error()
k.Logger(ctx).Error("tx post processing failed", "error", err)

// If the tx failed in post processing hooks, we should clear the logs
res.Logs = nil
} else if commit != nil {
// PostTxProcessing is successful, commit the tmpCtx
commit()
Expand Down