Problem: clear logs if tx failed in post processing hooks

evmos · Jun 15, 2022 · 13c8467 · 13c8467
1 parent 8f932dd
commit 13c8467
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/x/evm/handler_test.go b/x/evm/handler_test.go
@@ -599,6 +599,7 @@ func (suite *EvmTestSuite) TestERC20TransferReverted() {
 
 			suite.Require().True(res.Failed())
 			suite.Require().Equal(tc.expErr, res.VmError)
+			suite.Require().Empty(res.Logs)
 
 			after := k.GetBalance(suite.ctx, suite.from)
 

diff --git a/x/evm/keeper/state_transition.go b/x/evm/keeper/state_transition.go
@@ -277,6 +277,11 @@ func (k *Keeper) ApplyTransaction(ctx sdk.Context, tx *ethtypes.Transaction) (*t
 		}
 	}
 
+	// If the tx failed in post processing hooks, we should clear the logs
+	if res.Failed() {
+		res.Logs = nil
+	}
+
 	// refund gas in order to match the Ethereum gas consumption instead of the default SDK one.
 	if err = k.RefundGas(ctx, msg, msg.Gas()-res.GasUsed, cfg.Params.EvmDenom); err != nil {
 		return nil, sdkerrors.Wrapf(err, "failed to refund gas leftover gas to sender %s", msg.From())