-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Star skeleton #98
Conversation
May want to consolidate the types a bit, make it easier to follow. |
docs/crocks/Star.md
Outdated
@@ -0,0 +1,61 @@ | |||
# Star | |||
|
|||
`Monad m => Star a (m b)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep 🌽 and only try to say Star a b
, but here are some ideas I came up with:
-
Star a (Monad b)
-
Star a b
. Monad m => b ~> m b
-
Star a (m b)
. Monad m
The superstar inside me says "keep the laws implicit until skeleton is drawn!"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the docs. thanks.
Like I said in gitter and on pr#99. I am going to go with what I did there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anytime! I thought the new line could better say "under the implication of" or "constraint on". the .
was just a poopie way of indenting. Great jorb never less!!
A Super Star is what you are
This PR adds another skeleton to the docs for this issue#42. This one for the
Star
. Also in anticipation of the removal of the monoidial implementation onArrow
(broken in sooo many ways), this PR also removes theconcat
,empty
andvalue
bits off ofArrow