Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add both to Arrow and Star with an additional pointfree function #46

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Add both to Arrow and Star with an additional pointfree function #46

merged 1 commit into from
Feb 2, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Feb 1, 2017

You can have it both ways!!

This PR addresses issue#36 and does the following:

  • Add a both point-free function that accepts: Arrow, Function or Star.
  • Add both to Arrow
  • Add both to Star

In addition to that did a little 💄 on a few things I noticed:

  • Fix up coverage to set limits to 100% (:100:)
  • Exclude stuffs I do not care about from coverage reporting
  • Updated the siggy for safeLift.
  • Remove needless null defaulting for context argument to Async.fromNode
  • Fix up type checking for both first and second pointfree functions.

@evilsoft evilsoft mentioned this pull request Feb 1, 2017
Closed
4 tasks
@evilsoft evilsoft added this to the v0.2.3 milestone Feb 1, 2017
@coveralls
Copy link

coveralls commented Feb 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9f0b486 on both-to-arrow-star into 0072599 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9f0b486 on both-to-arrow-star into 0072599 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9f0b486 on both-to-arrow-star into 0072599 on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Feb 2, 2017

@evilsoft evilsoft merged commit 0127d9e into master Feb 2, 2017
@evilsoft evilsoft deleted the both-to-arrow-star branch February 2, 2017 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@evilsoft @coveralls