Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ES6 Rest operator instead of slicing arguments. #147

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Oct 1, 2017

We can do it, we have the tech

Now that we are doing the whole buble thing, makes sense to use the built in Rest operator instead of casting to an array. In order to accomplish this, we had to move some of the test mocks into the src folder to make sure things pass on versions 4 and 5 of node. Due to the mocks being moved, the build, publish, linting and coverage flows had to be updated.

Also removed the constant and identity functions from the core folder and substituted with their implementations when needed. Mostly these occurred in the specs, so it did not make sense to keep such simple functions in core.

@coveralls
Copy link

coveralls commented Oct 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a7b3413 on moar-clean into 99987fe on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Oct 1, 2017

image

@evilsoft evilsoft merged commit 0662911 into master Oct 1, 2017
@evilsoft evilsoft deleted the moar-clean branch October 1, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants