Move to ES6 Rest operator instead of slicing arguments. #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do it, we have the tech
Now that we are doing the whole
buble
thing, makes sense to use the built in Rest operator instead of casting to an array. In order to accomplish this, we had to move some of the test mocks into the src folder to make sure things pass on versions 4 and 5 of node. Due to the mocks being moved, the build, publish, linting and coverage flows had to be updated.Also removed the
constant
andidentity
functions from the core folder and substituted with their implementations when needed. Mostly these occurred in the specs, so it did not make sense to keep such simple functions incore
.