Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up All, Any, Arrow and Pair #141

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Clean up All, Any, Arrow and Pair #141

merged 1 commit into from
Aug 1, 2017

Conversation

evilsoft
Copy link
Owner

@evilsoft evilsoft commented Aug 1, 2017

They can't all be zingers

image

As the various READMEs and Documentation is being add, we will be taking the opertunity to do some things that needed to be done to each of the Types in crocks:

  1. Make sure all specs around errors are looking for the exact error message instead of simply looking for TypeErrors.
  2. Remove all dependency on internal functions like compose, constant, identity, etc. It is cool for things like implements and inspect. Mostly want to remove dependencies on the functions that are available in the public API. (This helps keep the noise down on the stacks when we throw, as well as makes it easier to ship with a small core when we get all monorepo)
  3. Remove any derived functions (like map and ap derived from chain).
  4. Consolidate type checks in the algebras when possible.

This is the first wave, will be doing these for every ADT in the lib. These PRs will be driven by the documentation of the individual namespaces.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 94253fc on more-cleanup into 06f91c1 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 94253fc on more-cleanup into 06f91c1 on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Aug 1, 2017

image

@evilsoft evilsoft merged commit c8f937a into master Aug 1, 2017
@evilsoft evilsoft deleted the more-cleanup branch August 1, 2017 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants