Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent type on inspect string for sum types #115

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

evilsoft
Copy link
Owner

What does that even mean?!?

image

Found that prefixing the type was so gross in practice. After seeing something that @joneshf did with his toString function on his Trees read sooo much better. So we gonna drop dat type from the inspect string. So instead of Maybe.Just 23, only going to show Just 23

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 46fce76 on better-sum-type-inspects into f07abc5 on master.

@evilsoft
Copy link
Owner Author

evilsoft commented Apr 6, 2017

image

@evilsoft evilsoft merged commit a923539 into master Apr 6, 2017
@evilsoft evilsoft deleted the better-sum-type-inspects branch April 6, 2017 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants