added toBoolean to handle abbreviations prop string value

evidence-dev · Jan 15, 2025 · c3ff561 · c3ff561
1 parent a8edba2
commit c3ff561
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/afraid-pumpkins-destroy.md b/.changeset/afraid-pumpkins-destroy.md
@@ -0,0 +1,5 @@
+---
+'@evidence-dev/core-components': patch
+---
+
+fixed US map abbreviaabbreviations string handling
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/map/USMap.stories.svelte b/packages/ui/core-components/src/lib/unsorted/viz/map/USMap.stories.svelte
@@ -37,3 +37,9 @@
 	{@const data = Query.create(`SELECT * from state_sales`, slowQuery)}
 	<USMap {data} {...args} state="state" value="sales" />
 </Story>
+
+<Story name="No Abb" let:args>
+	{@const data = Query.create(`SELECT * from state_sales`, query)}
+	<USMap {data} {...args} state="state" value="sales" abbreviations="false" />
+	<USMap {data} {...args} state="state" value="sales" abbreviations={false} />
+</Story>
diff --git a/packages/ui/core-components/src/lib/unsorted/viz/map/_USMap.svelte b/packages/ui/core-components/src/lib/unsorted/viz/map/_USMap.svelte
@@ -16,6 +16,7 @@
 	import InvisibleLinks from '../../../atoms/InvisibleLinks.svelte';
 	import { getThemeStores } from '../../../themes/themes.js';
 	import { checkDeprecatedColor } from '../../../deprecated-colors.js';
+	import { toBoolean } from '../../../utils.js';
 
 	const { theme, resolveColorPalette, resolveColorScale } = getThemeStores();
 
@@ -95,7 +96,7 @@
 	export let connectGroup = undefined;
 
 	export let abbreviations = false;
-	$: abbreviations = abbreviations === 'true' || abbreviations === true;
+	$: abbreviations = toBoolean(abbreviations);
 
 	let nameProperty = abbreviations ? 'abbrev' : 'name';