Add basic linting rules #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mms-gianni
reviewed
Nov 10, 2023
| ForwardedFor = getenv("X_FORWARDED_FOR", "66.249.66.1") | ||
| rulesSet = loadRules() | ||
| allowedDomains = strings.Split(os.Getenv("ALLOWED_DOMAINS"), ",") | ||
| ) |
|
I like this idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely opinionated, and the golangci-lint configuration file was taken from another project of mine (based on what I thought was restrictive enough).
One of these commits also fixes some dependency issues after running
go mod tidy.A separate thing that can be added later is a workflow to run golangci-lint after every commit. The makefile I added provides an install step for recommended linters so anyone can run them locally.