Merge pull request #684 from evershopcommerce/dev

fix: Coupon subtotal condition is not working #683
evershopcommerce · Jan 11, 2025 · 702498a · 702498a
2 parents 8aa4a85 + 6e556bf
commit 702498a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/changelog.md b/changelog.md
diff --git a/packages/evershop/src/modules/promotion/services/registerDefaultValidators.js b/packages/evershop/src/modules/promotion/services/registerDefaultValidators.js
@@ -86,14 +86,16 @@ module.exports.registerDefaultValidators =
         )
           ? parseFloat(conditions.order_total)
           : null;
-        if (
-          minimumSubTotal && priceIncludingTax
-            ? cart.getData('sub_total_incl_tax')
-            : cart.getData('sub_total') < minimumSubTotal
-        ) {
-          return false;
+        if (minimumSubTotal === null) {
+          return true;
         }
-        return true;
+        let check = false;
+        if (priceIncludingTax) {
+          check = cart.getData('sub_total_incl_tax') >= minimumSubTotal;
+        } else {
+          check = cart.getData('sub_total') >= minimumSubTotal;
+        }
+        return check;
       },
       function minimumQtyValidator(cart, coupon) {
         const conditions = coupon.condition;