Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Carthage support for the EVReflection/CloudKit subspec. #225

Merged

Conversation

jstheoriginal
Copy link
Contributor

First time doing a Carthage framework support PR so hopefully it's correct. It successfully builds. Thanks!

@evermeer
Copy link
Owner

evermeer commented Sep 5, 2017

Thanks! I will have a look at it later today.

@jstheoriginal
Copy link
Contributor Author

No prob. Also I successfully used my branch in the PR to integrate the CloudKit subspec into my app with EVCloudKitDao so it works all on that end after I imported EVReflection_CloudKit instead of EVReflection. 👍

@evermeer evermeer merged commit 85bf950 into evermeer:master Sep 6, 2017
@evermeer
Copy link
Owner

evermeer commented Sep 6, 2017

For now it's OK, but I might rename EVReflection_CloudKit to EVReflection_CloudKit_iOS later on if there is ever a need for a non iOS version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants