[Fix] Fix build errors issues for MCP server electron desktop app #9068
Conversation
|
Warning Rate limit exceeded@RolandM99 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThis change updates build and configuration files for the MCP server. It adjusts package entry points and dependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR fixes build configuration issues for the MCP (Model Context Protocol) server, a new Electron-based desktop application in the Ever Gauzy ecosystem. The changes address three key areas:
-
Build Pipeline Integration: The root
package.jsonis updated to include MCP server build commands (build:mcp-serverandbuild:mcp-server:prod) in the comprehensive build orchestration scripts. This ensures the MCP server is built alongside other packages when runningbuild:package:allvariants. -
Electron Entry Point Fix: The MCP server's
package.jsoncorrects the main entry point fromindex.jstomain.js, aligning with the actual compiled Electron main file structure. The binary command reference is also updated accordingly. -
Dependency Cleanup: Removes the
@gauzy/configdependency and workspace reference from the MCP server package, which was likely causing build conflicts since the MCP server imports configuration directly from@gauzy/mcp-server. -
TypeScript Configuration: Updates
tsconfig.electron.jsonto extend the base TypeScript configuration and removes the 'electron' type definition that was potentially causing type conflicts, keeping only 'node' types.
These changes integrate the MCP server into the existing build system while resolving configuration mismatches that were preventing successful Electron app compilation.
PR Description Notes:
- The PR template checkboxes are not completed
- Missing explanation of what the changes do and why they add value
Confidence score: 3/5
- This PR appears safe to merge as it primarily fixes build configuration issues without affecting runtime logic
- The score reflects concerns about incomplete PR template and potential inconsistency in docker build configuration
- The
apps/server-mcp/tsconfig.electron.jsonfile needs careful review as TypeScript configuration changes can have subtle effects
3 files reviewed, 1 comment
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
apps/server-mcp/src/package.json(2 hunks)apps/server-mcp/tsconfig.electron.json(2 hunks)package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: apps/mcp/tsconfig.json:13-14
Timestamp: 2025-07-23T16:00:29.020Z
Learning: In the ever-co/ever-gauzy project, empty "files" and "include" arrays in TypeScript configuration files (like apps/mcp/tsconfig.json) are written deliberately and should not be flagged as issues. The project intentionally uses this pattern where configurations rely solely on referenced configs via the "references" array.
apps/server-mcp/tsconfig.electron.json (12)
Learnt from: RolandM99
PR: #9029
File: apps/mcp/tsconfig.json:13-14
Timestamp: 2025-07-23T16:00:29.020Z
Learning: In the ever-co/ever-gauzy project, empty "files" and "include" arrays in TypeScript configuration files (like apps/mcp/tsconfig.json) are written deliberately and should not be flagged as issues. The project intentionally uses this pattern where configurations rely solely on referenced configs via the "references" array.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: CR
PR: ever-co/ever-gauzy#0
File: .cursor/rules/angular.mdc:0-0
Timestamp: 2025-07-21T15:50:57.938Z
Learning: Applies to src/**/*.{ts,tsx} : Match file names to the TypeScript identifier within; avoid generic names like 'helpers.ts', 'utils.ts', or 'common.ts'
Learnt from: syns2191
PR: #8909
File: packages/desktop-activity/src/lib/kb-mouse.ts:1-2
Timestamp: 2025-04-20T09:30:18.913Z
Learning: When importing Node.js built-in modules in TypeScript/JavaScript files, use the node: protocol prefix (e.g., import { EventEmitter } from 'node:events'; instead of import { EventEmitter } from 'events';) as it's more explicit and signals that the imported module belongs to Node.js.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: rahul-rocket
PR: #8922
File: packages/plugins/integration-upwork/package.json:57-57
Timestamp: 2025-04-28T14:17:18.486Z
Learning: UUID version 11+ includes its own TypeScript definitions, making the separate @types/uuid package unnecessary. When using UUID v11 or newer, remove the @types/uuid dependency to avoid potential type conflicts.
Learnt from: rahul-rocket
PR: #8922
File: packages/plugins/integration-upwork/package.json:57-57
Timestamp: 2025-04-28T14:17:18.486Z
Learning: UUID version 11+ includes its own TypeScript definitions, making the separate @types/uuid package unnecessary. When using UUID v11 or newer, remove the @types/uuid dependency to avoid potential type conflicts.
Learnt from: CR
PR: ever-co/ever-gauzy#0
File: .cursor/rules/angular.mdc:0-0
Timestamp: 2025-07-21T15:50:57.938Z
Learning: Applies to src/**/*.{ts,html,css,scss,sass,less,styl} : Use the same file name for a component's TypeScript, template, and styles (e.g., 'user-profile.ts', 'user-profile.html', 'user-profile.css')
Learnt from: CR
PR: ever-co/ever-gauzy#0
File: .cursor/rules/angular.mdc:0-0
Timestamp: 2025-07-21T15:50:57.938Z
Learning: Applies to src/main.ts : Bootstrap your application in a file named 'main.ts' directly inside 'src'
Learnt from: CR
PR: ever-co/ever-gauzy#0
File: .cursor/rules/angular.mdc:0-0
Timestamp: 2025-07-21T15:50:57.938Z
Learning: Applies to src/**/*.{ts,tsx} : Directives should use the same application-specific prefix as your components; attribute selectors for directives should use camelCase (e.g., '[mrTooltip]')
Learnt from: syns2191
PR: #9033
File: packages/desktop-activity/src/lib/activity-window.ts:113-120
Timestamp: 2025-07-11T01:30:50.701Z
Learning: In the ever-gauzy codebase, the build system compiles all static import statements to require statements. When working with ESM-only modules like 'get-windows', the Function constructor approach with dynamic import is used to bypass build-time transformations, as seen in packages/desktop-activity/src/lib/activity-window.ts.
apps/server-mcp/src/package.json (5)
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: #9029
File: apps/mcp/tsconfig.json:13-14
Timestamp: 2025-07-23T16:00:29.020Z
Learning: In the ever-co/ever-gauzy project, empty "files" and "include" arrays in TypeScript configuration files (like apps/mcp/tsconfig.json) are written deliberately and should not be flagged as issues. The project intentionally uses this pattern where configurations rely solely on referenced configs via the "references" array.
Learnt from: RolandM99
PR: #8863
File: packages/plugins/integration-zapier/zapier/src/authentication.ts:29-29
Timestamp: 2025-04-02T09:39:39.648Z
Learning: When developing Zapier integrations that will be deployed to the Zapier platform, use process.env directly to access environment variables instead of importing from @gauzy/config, as Zapier's platform cannot recognize or import this package.
package.json (3)
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: test
- GitHub Check: build
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (4)
apps/server-mcp/src/package.json (3)
21-24: Confirmmain.js& bin resolution at build timeThe entry point and CLI binary were switched from
index.jstomain.js. Make sure:
main.jsis generated in the package root (apps/server-mcp/src/) during thenx build server-mcpstep.- The file has its executable bit set (for *nix) so the
gauzy-mcpbin works without manualchmod.Failure to do either will break both
electron-builderpackaging andnpx gauzy-mcp.
26-29: Removal ofdist/packages/configworkspace – check transitive importsThe workspace array now only points to
mcp-server. If any code insideserver-mcpstill importsimport { ... } from '@gauzy/config';Yarn will no longer hoist that package, producing runtime
MODULE_NOT_FOUND. Double-check imports or add the package back.
124-140: No@gauzy/configimports detected – safe to remove dependency
Ranrg --no-heading -n "@gauzy/config" apps/server-mcp/srcwith zero matches. There are no remaining imports, so dropping@gauzy/configis confirmed safe.apps/server-mcp/tsconfig.electron.json (1)
2-2: 👍 Extending the base config is cleanAdding
"extends": "./tsconfig.json"removes duplication and keeps compiler rules centralised.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: apps/mcp/tsconfig.json:13-14
Timestamp: 2025-07-23T16:00:29.020Z
Learning: In the ever-co/ever-gauzy project, empty "files" and "include" arrays in TypeScript configuration files (like apps/mcp/tsconfig.json) are written deliberately and should not be flagged as issues. The project intentionally uses this pattern where configurations rely solely on referenced configs via the "references" array.
package.json (4)
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: #9063
File: .scripts/env.ts:354-356
Timestamp: 2025-07-29T08:07:12.448Z
Learning: In .scripts/env.ts, APP_ID environment variable defaults use lowercase format (e.g., 'com.ever.gauzydesktoptimer', 'com.ever.gauzydesktop', 'com.ever.gauzyserver') rather than camelCase. New APP_ID values should maintain this lowercase consistency.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: test
- GitHub Check: build
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
package.json (1)
290-291: MCP-server is now wired into all build cascades – looks goodThe three
build:package:all*scripts now invoke the correspondingbuild:mcp-server*tasks, fixing the omission flagged in the previous review.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9068
File: apps/server-mcp/tsconfig.electron.json:17-18
Timestamp: 2025-07-29T21:00:16.275Z
Learning: In the ever-co/ever-gauzy project's apps/server-mcp/tsconfig.electron.json, the "electron" type should be removed from the types array because the project no longer uses Electron APIs and has moved to a Node.js-only architecture. Adding "electron" types causes build errors in their current setup, so only "node" types should be included.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: ever-co/ever-gauzy#9029
File: apps/mcp/tsconfig.json:13-14
Timestamp: 2025-07-23T16:00:29.020Z
Learning: In the ever-co/ever-gauzy project, empty "files" and "include" arrays in TypeScript configuration files (like apps/mcp/tsconfig.json) are written deliberately and should not be flagged as issues. The project intentionally uses this pattern where configurations rely solely on referenced configs via the "references" array.
package.json (5)
Learnt from: RolandM99
PR: #9068
File: apps/server-mcp/tsconfig.electron.json:17-18
Timestamp: 2025-07-29T21:00:16.275Z
Learning: In the ever-co/ever-gauzy project's apps/server-mcp/tsconfig.electron.json, the "electron" type should be removed from the types array because the project no longer uses Electron APIs and has moved to a Node.js-only architecture. Adding "electron" types causes build errors in their current setup, so only "node" types should be included.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/config/server-info.ts:2-2
Timestamp: 2025-07-25T04:53:31.370Z
Learning: In packages/mcp-server/src/lib/config/server-info.ts, the user RolandM99 confirmed that the server name "Gauzy MCP Server" should remain hardcoded because it will stay the same across all environments (development, staging, production). The user prefers this approach over using environment variables for the server name.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is used consistently across most tool files for logging, but some files (employees.ts, tasks.ts, daily-plan.ts) still use console.error creating an inconsistency. The electron-log library works in both Electron and Node.js contexts, so it's safe to use throughout the shared package for consistent logging behavior.
Learnt from: RolandM99
PR: #9029
File: packages/mcp-server/src/lib/tools/employees.ts:78-600
Timestamp: 2025-07-25T05:08:34.515Z
Learning: In the ever-co/ever-gauzy packages/mcp-server shared package, electron-log is successfully used across multiple core files (api-client.ts, auth-manager.ts, mcp-server.ts, etc.) without any conditional logic or fallbacks. This proves electron-log works reliably in both Electron and standalone Node.js contexts within this codebase. The files using console.error (employees.ts, tasks.ts, daily-plan.ts) are inconsistent outliers that should use log.error for consistency.
Learnt from: RolandM99
PR: #9063
File: .scripts/env.ts:354-356
Timestamp: 2025-07-29T08:07:12.448Z
Learning: In .scripts/env.ts, APP_ID environment variable defaults use lowercase format (e.g., 'com.ever.gauzydesktoptimer', 'com.ever.gauzydesktop', 'com.ever.gauzyserver') rather than camelCase. New APP_ID values should maintain this lowercase consistency.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: test
- GitHub Check: build
🔇 Additional comments (1)
package.json (1)
290-291:mcp-serveris now part of the aggregated build – looks good
Includingbuild:mcp-server(and its:prodflavour) in the umbrellabuild:package:all*scripts resolves the missing artefact that previously broke downstream builds.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
[Fix] Fix build errors issues for MCP server electron desktop app Co-authored-by: Roland MN <[email protected]>
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.