Add method to filter partial documents #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeliner
force-pushed
the
feature/filter_partial_docs
branch
from
6592e72 to
dbb22d3
Compare
Also make sure that filterDocs and filterPartialDocs return a \Traversable that provides docId as key.
codeliner
force-pushed
the
feature/filter_partial_docs
branch
from
dbb22d3 to
dae2b5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method
findPartialDocsand aPartialSelectclass to specify which fields should be included in the result docs.This PR also includes a long planned correction for accessing docIds:
filterDocsis deprectaed now and will be replaced byfindDocs. The difference between the two is that the latter uses docIds as iterator keys. This is a breaking change and therefor introduced with a new method and deprecation of the oldfilterDocsmethod. So people have time to adjust query logic.