-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Lambda Zewotherm: use "E-Eintrag" mode only [BC] #22811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lambda template corrected for E-Eintrag setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fzahn - I've reviewed your changes - here's some feedback:
- Since removing the 'excess' parameter hardcodes scale to 1, please verify that import/export semantics are still handled correctly without needing a negative multiplier.
- This change removes an existing parameter, so consider bumping the template version or adding a changelog entry to signal the breaking change.
- Double-check that the new "Energy-Input" measuring point label exactly matches the device or EVCC documentation to prevent user confusion.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since removing the 'excess' parameter hardcodes scale to 1, please verify that import/export semantics are still handled correctly without needing a negative multiplier.
- This change removes an existing parameter, so consider bumping the template version or adding a changelog entry to signal the breaking change.
- Double-check that the new "Energy-Input" measuring point label exactly matches the device or EVCC documentation to prevent user confusion.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Excess-parameter remains and set to deprecated
scale not needed for deprecated param excess
description for excess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Is fixed |
|
Could you please clarify the intent of this PR? In particular:
For reference, from the Lambda Modbus Spec - Register 102 Name
Data Format
Register desciption
(source: https://lambda-wp.at/wp-content/uploads/2025/02/Modbus-Beschreibung-und-Protokoll.pdf) |
|
Hi, Best regards, |
|
I've left the BC marker for heads-up, but it really isn't breaking as the old configuration was broken anyway. |
|
My Lambda heat pump is configured with “Neg. E-Überschuss” — a fixed setting that I cannot change myself; it can only be adjusted by Lambda or someone with elevated access. I’ve been running evcc in this configuration "excess: minus" for about a week, and the test phase has looked quite positive so far. While I haven’t done exhaustive testing, here’s what I’ve observed:
Could you please explain what is actually fixed by removing the "excess: minus" option? Removing this parameter does break my setup, as the Lambda expects negative values in “Neg. E-Überschuss” mode. |
|
@anbie I see your problem. Please contact your installer to get the level2-password for the lambda, which is required to change the setting to "E-Eintrag". So strongly recommend to have your installer change the setting to E-Eintrag (or ask Lambda-support to do that for you, they seem to have a good support) |
|
@anbie Irrespective of this change, your current installer settings just don't fit how evcc works. This is already a problem without this PR, hence doesn't make a difference. If you're happy with how it's working (though not perfectly) just leave it as-is. |
|
@andig I’m pretty sure that “just leaving it as-is” will actually stop working once this PR is shipped. This change removes the scale statement from the setmaxpower section in the template: Without that, negative numbers will no longer be generated and sent to Lambda’s register 102. Since my Lambda is in “Neg. E-Überschuss” mode removing the scale will break the current working but not perfect behavior in my setup. |
|
if you change the setting to „E-Eintrag“ on your Lambda, you are out of trouble and have a setup, that will work more reliable
|
|
@anbie autsch, danke für den Hinweis. As discussed, your setup is "wrong" but I also realise you can't fix it. I'd suggest we add @fzahn wdyt? We can also leave out the minus and just add a new scale param |
|
Hi, Regards, |
|
I opened a new PR for that change. I was not able to reuse the excess-parameter, when it was set to deprecated. so I have removed the deprecated setting and made the parameter excess advanced. So we now have the backwards -compatibility |
Lambda template corrected for E-Eintrag setting. With this setting the Lambda is allowed to consume the power, that EVCC reports.