Varta: add battery control

[zoomy01]

#19631

[sourcery-ai]

Hey @zoomy01 - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[VolkerK62]

Vorschlag:
den Parameter dischargepower als positiven Wert ausführen und das entsprechende Scaling innerhalb batterymode machen.
Ich denke, das ist intuitiver.

[zoomy01]

den Parameter dischargepower bräuchte es innerhalb von evvc eigentlich nicht, da er für nichts genutzt wird.

Gibt es eine Möglichkeit den Ist-Wert aus Register 1074 zu irgendwo zu speichern, wenn hold aktiviert wird und beim Wechsel auf normal diesen Wert wieder zurück zu schreiben?

[andig]

Nein, gibts nicht :/

[zoomy01]

Wäre toll wenn nochmal jemand drüber gucken könnte. Ich weiß leider nicht warum die defaults.yaml einen Konflikt hat und freue mich über einen Tipp.

[sourcery-ai]

Hey @zoomy01 - I've reviewed your changes - here's some feedback:

• The batterymode block’s indentation looks off compared to the surrounding YAML—please align it with the other fields to avoid rendering issues.
• You’re hardcoding timeout: 120s in the batterymode section instead of using the {{ .watchdog }} parameter—consider switching to the template variable for flexibility.
• The maxdischargepower param is defined both in varta.yaml and in defaults.yaml—please consolidate it to a single definition to avoid duplication.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- The `batterymode` block’s indentation looks off compared to the surrounding YAML—please align it with the other fields to avoid rendering issues.
- You’re hardcoding `timeout: 120s` in the `batterymode` section instead of using the `{{ .watchdog }}` parameter—consider switching to the template variable for flexibility.
- The `maxdischargepower` param is defined both in `varta.yaml` and in `defaults.yaml`—please consolidate it to a single definition to avoid duplication.

## Individual Comments

### Comment 1
<location> `templates/definition/meter/varta.yaml:27` </location>
<code_context>
   - name: host
   - name: port
     default: 502
+  - name: watchdog
+    type: duration
+    default: 120s
</code_context>

<issue_to_address>
Add description/help for 'watchdog' parameter

Adding a localized description or help text for 'watchdog' will enhance documentation and make the parameter easier to understand for users.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
  - name: watchdog
    type: duration
    default: 120s
    usages: ["battery"]
    advanced: true
=======
  - name: watchdog
    type: duration
    default: 120s
    help:
      de: Zeit in Sekunden, nach der der Watchdog auslöst, wenn keine Kommunikation erfolgt
      en: Time in seconds after which the watchdog triggers if no communication occurs
    usages: ["battery"]
    advanced: true
>>>>>>> REPLACE

</suggested_fix>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[andig]

Was fehlt hier noch?

[zoomy01]

Was fehlt hier noch?

von meiner Seite nicht. ;)