Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub and npm are recommending that maintainers for packages such as esbuild switch to trusted publishing. With this change, a VM on GitHub will now build and publish all of esbuild's packages to npm instead of me. In theory.
Unfortunately there isn't really a way to test that this works other than to do it live. So the next release will be that live test. Hopefully it's uneventful and is exactly the same as the previous one (well, except for the green provenance attestation checkmark on npm that happens with trusted publishing).
The basic idea in this change is that every pushed commit that changes
version.txtwill trigger a new release attempt. This is explained in detail in the newRUNBOOK.mdfile. I did it that way because it's similar to how releases currently work and it seemed simple enough.Releasing esbuild involves coordinating between three separate repos. Previously the release process would commit and push to these repos as part of the release process. But doing that from a GitHub workflow doesn't seem straightforward, so I've changed these into a polling workflow on the other two repos. This seems ok for now because it should be fine that they don't update simultaneously with the release. They will update with at most a 6 hour delay.
Fixes #4281