Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#74] Remove raiseError accessor param. #75

Merged
merged 2 commits into from
Sep 3, 2019
Merged

[#74] Remove raiseError accessor param. #75

merged 2 commits into from
Sep 3, 2019

Commits on Sep 2, 2019

  1. [#74] Remove raiseError accessor param. 

    If an accessor cannot process an input value, it should just throw an exception instead.

There is a trade-off to this approach, in that the stacktrace for the accessor-thrown error is not preserved (replaced by `_raiseError()`), but accessors tend to be fairly simple in implementation, so it shouldn' be too difficult to locate the source of an error.
    @todofixthis
    todofixthis committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    b1062a2 View commit details
    Browse the repository at this point in the history

  2. [#74] Refactored now-unnecessarily-complex function 🍃

    @todofixthis
    todofixthis committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    7914938 View commit details
    Browse the repository at this point in the history