Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type of asEmailString() according to PR #158 #160

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

hckhanh
Copy link
Contributor

@hckhanh hckhanh commented Sep 2, 2022

Hi @evanshortiss, I realize that the type of asEmailString() is missing, I put some changes

@hckhanh hckhanh changed the title Add missing type of asEmailString according to PR #158 Add missing type of asEmailString() according to PR #158 Sep 2, 2022
@evanshortiss
Copy link
Owner

Thank you! Could you also add it to the VariableAccessors here: https://github.com/evanshortiss/env-var/blob/master/env-var.d.ts#L107

Copy link
Owner

@evanshortiss evanshortiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to make sure it's also in the VariableAccessors interface.

@hckhanh
Copy link
Contributor Author

hckhanh commented Sep 3, 2022

ok @evanshortiss, I add the missing type to VariableAccessors interface.

@evanshortiss evanshortiss merged commit 0686973 into evanshortiss:master Sep 6, 2022
@evanshortiss
Copy link
Owner

Releasing as 7.3.0, thanks @hckhanh !

@hckhanh hckhanh deleted the missing-type branch November 2, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants