Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to ensure arrays are not empty. handle numeric typings better for defaults #16

Merged
merged 1 commit into from
Dec 12, 2017
Merged

update to ensure arrays are not empty. handle numeric typings better for defaults #16

merged 1 commit into from
Dec 12, 2017

Conversation

evanshortiss
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Dec 12, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 61b2d03 on types-arrays into 7bfa68b on master.

@evanshortiss evanshortiss merged commit 8d9ec83 into master Dec 12, 2017
@caccialdo
Copy link
Contributor

I'm not sure I grasp the decision process that lead to this PR. My first intuition regarding this scenario was:

COMMA_ARRAY= => [] if not required and Error otherwise
COMMA_ARRAY=foo => ["foo"]
COMMA_ARRAY=foo,bar => ["foo", "bar"]

I'd be interested in knowing the reason for the logic in this PR. Could explain it to me please?

@gabrieloczkowski gabrieloczkowski mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanshortiss @coveralls @caccialdo