Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate identifier for EnvVarError #151

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

avocadomaster
Copy link
Contributor

#150 to avoid ts error. EnvVarError class is exported on line 263

../../env-var/env-var.d.ts:263:14 - error TS2300: Duplicate identifier 'EnvVarError'.

263 export class EnvVarError extends Error {}
                 ~~~~~~~~~~~

../../env-var/env-var.d.ts:308:14 - error TS2300: Duplicate identifier 'EnvVarError'.

308 export const EnvVarError: EnvVarError
                 ~~~~~~~~~~~


Found 2 errors.

@coveralls
Copy link

coveralls commented Oct 29, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 355e6c0 on avocadomaster:master into 03f4fc2 on evanshortiss:master.

@evanshortiss
Copy link
Owner

Thank you @avocadomaster. I'm not sure why this wasn't caught by tests. I'll really need to look into better TS typing tests.

@evanshortiss evanshortiss merged commit f60ff5d into evanshortiss:master Oct 29, 2021
@evanshortiss
Copy link
Owner

Issues like this will now be caught due to 47195ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants