Fix type definitions of .asUrlObject() and comments of .asUrlString() #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @aautio |
evanshortiss
added a commit
that referenced
this pull request
Jun 12, 2020
* docs: add note about asUrlString() pathname behaviour * chore: include Node.js v14 in target CI versions * feat: add internal accessors to the public API * docs: update CHANGELOG with 6.2.0 notes * chore: bump package version * docs: update CHANGELOG with Node.js v14 note * feat: add logging and logger support * docs: update CHANGELOG with logger support notes * 6.2.0-alpha.0 * docs: remove extra period Co-authored-by: Evan <[email protected]> * docs: correct position stated in above/below for accessors Co-authored-by: Evan <[email protected]> * docs: correct position stated in above/below for accessors Co-authored-by: Evan <[email protected]> * docs: add DigiPie to contributors list * fix: prevent accidental leakage of environment values * Contribute to 6.2.0 (#129) * docs: correct typos * chore: update .editorconfig to use single quotes * docs: custom-accessor.js * docs: update README with custom-accessor example * docs: update custom-accessor.js * chore: prep CHANGELOG and package for 6.2.0 release * Add @DigiPie as a contributor * fix: extension typing error (#131) * fix: type definitions of .asUrlObject() and comments of .asUrlString() (#132) * docs: update contrubutors list * chore: commit formatting changes for example * docs: CHANGELOG updates for release Co-authored-by: Evan <[email protected]> Co-authored-by: Debove Christopher <[email protected]> Co-authored-by: Ari Autio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.asUrlObject() returns an URL instance instead of an Url. Fixed the docs to match the upcoming ones in 6.2.0.
This PR is based on 6.x -branch.