[#74] Refactored now-unnecessarily-complex function 🍃

evanshortiss · Sep 2, 2019 · 7914938 · 7914938
1 parent b1062a2
commit 7914938
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/lib/variable.js b/lib/variable.js
@@ -12,13 +12,11 @@ module.exports = function getVariableAccessors (container, varName, defValue) {
   let isBase64 = false
 
   /**
-   * Generate a function to throw an error
+   * Throw an error with a consistent type/format.
    * @param {String} value
    */
-  function generateRaiseError (value) {
-    return function _raiseError (msg) {
-      throw new EnvVarError(`"${varName}" ${msg}, but was "${value}"`)
-    }
+  function raiseError (value, msg) {
+    throw new EnvVarError(`"${varName}" ${msg}, but was "${value}"`)
   }
 
   /**
@@ -43,7 +41,7 @@ module.exports = function getVariableAccessors (container, varName, defValue) {
 
       if (isBase64) {
         if (!value.match(base64Regex)) {
-          generateRaiseError(value)('should be a valid base64 string if using convertFromBase64')
+          raiseError(value, 'should be a valid base64 string if using convertFromBase64')
         }
 
         value = Buffer.from(value, 'base64').toString()
@@ -57,7 +55,7 @@ module.exports = function getVariableAccessors (container, varName, defValue) {
           args
         )
       } catch (error) {
-        generateRaiseError(value)(error.message)
+        raiseError(value, error.message)
       }
     }
   }