Fix 1.0 not recognized as float (#166)

* Fix 1.0 not recognized as float * Add another invalid float test * Add second isNaN explanation to `asFloat` --------- Co-authored-by: Dror Weiss <>
evanshortiss · Apr 24, 2023 · 7629cd9 · 7629cd9
1 parent 7a47152
commit 7629cd9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/accessors/float.js b/lib/accessors/float.js
@@ -3,7 +3,9 @@
 module.exports = function asFloat (value) {
   const n = parseFloat(value)
 
-  if (isNaN(n) || n.toString() !== value) {
+  // Some values are parsed as valid floats despite being obviously invalid, e.g. "1.o" or "192.168.1.1".
+  // In these cases we would want to throw an error.
+  if (isNaN(n) || isNaN(value)) {
     throw new Error('should be a valid float')
   }
 

diff --git a/test/index.js b/test/index.js
@@ -12,6 +12,7 @@ describe('env-var', function () {
     INVALID_BASE_64: 'a|GV-sb*G8=',
     STRING: 'oh hai',
     FLOAT: '12.43',
+    FLOAT_INTEGER: '1.0',
     INTEGER: '5',
     BOOL: 'false',
     JSON: '{"name":"value"}',
@@ -227,6 +228,15 @@ describe('env-var', function () {
     it('should return a float', function () {
       expect(mod.get('FLOAT').asFloat()).to.be.a('number')
       expect(mod.get('FLOAT').asFloat()).to.equal(parseFloat(TEST_VARS.FLOAT))
+      expect(mod.get('FLOAT_INTEGER').asFloat()).to.equal(parseFloat(TEST_VARS.FLOAT_INTEGER))
+    })
+
+    it('should throw an exception - non float found', function () {
+      process.env.FLOAT = '1.o'
+
+      expect(function () {
+        mod.get('FLOAT').asFloat()
+      }).to.throw()
     })
 
     it('should throw an exception - non float found', function () {