Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BOOST_PP-related dispatch bug that affects 3-center derivatives when configured with --with-max-am=X --with-eri3-max-am=Y #324

Conversation

evaleev
Copy link
Owner

@evaleev evaleev commented Feb 1, 2024

resolves #308

…hen configured with `--with-max-am=X --with-eri3-max-am=Y`

If `AB` is `#define`d `BOOST_PP_CAT(AB,C) = BOOST_PP_CAT(BOOST_PP_CAT(A,B),C) != BOOST_PP_CAT(A,BOOST_PP_CAT(B,C))` ... else all are equivalent
@evaleev evaleev linked an issue Feb 1, 2024 that may be closed by this pull request
…for center-dependent momenta could yield (incorrect) result for angular momenta outside the supported range
@evaleev evaleev merged commit 1ccdad4 into master Feb 5, 2024
7 of 8 checks passed
@evaleev evaleev deleted the 308-assertion-failure-crash-while-computing-3-center-eri-derivatives branch February 5, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failure crash while computing 3-center ERI derivatives
1 participant