Output RichText #228
Merged
Output RichText #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichText enabled on Line and changed to a TextLabel since it wasn't being treated as a TextBox
outofbearspace
added a commit
to outofbearspace/Cmdr
that referenced
this pull request
Aug 19, 2022
undid duplicate changes made in evaera#228
evaera
pushed a commit
that referenced
this pull request
Aug 19, 2022
* Entry Line Behavior replaced "Line" TextBox with a TextLabel (wasn't being treated as a TextBox) uses a UIListLayout instead of relying on code to position entry box (a roblox update somehow broke the positioning) * Update CreateGui.lua undid duplicate changes made in #228
|
Not sure if I want to merge this. I don't particularly like RichText and I'm concerned about escaping RichText that is included in user input. If anything, it needs to be strictly opt-in per command |
This reverts commit 0439f41.
Opt-in RichText with backwards compatibility
|
I have changed it to be opt-in like you said, replacing the "color" parameter in the AddLine method with an options table (includes backwards compatibility) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
richtext enabled on output messages and changed "Line" to a textlabel since it wasn't being treated as a textbox
couldn't enable richtext on the entry line due to the way ui text rendering behaves
Closes #157