Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make symcc work with llvm 17 #149

Merged
merged 7 commits into from
Nov 24, 2023
Merged

Make symcc work with llvm 17 #149

merged 7 commits into from
Nov 24, 2023

Conversation

tokatoka
Copy link
Contributor

@tokatoka tokatoka commented Nov 6, 2023

llvm/Transforms/IPO/PassManagerBuilder.h doesn't exist on llvm 17

@aurelf
Copy link
Member

aurelf commented Nov 15, 2023

Thanks for the PR, I added some CI tests for LLVM 16 and 17.
I think there is something else to be done for the QSym backend (on LLVM 17)...

@tokatoka
Copy link
Contributor Author

I made the necessary change here
eurecom-s3/qsym#1

@tokatoka
Copy link
Contributor Author

this guy is not working eurecom-s3/qsym#1.
I'll check

@tokatoka
Copy link
Contributor Author

i don't get why this breaks even for llvm 11, 12, 13, 14, 15 where i changed nothing.

@tokatoka
Copy link
Contributor Author

I found out why
I need to add my change to symcc branch of eurecom-s3/qsym

eurecom-s3/qsym#3

then i'll update the submodule to symcc

@aurelf
Copy link
Member

aurelf commented Nov 23, 2023

Indeed, that was the wrong branch, got confused too... Thanks !

@tokatoka
Copy link
Contributor Author

sry i forgot to add ifdef
eurecom-s3/qsym#4

@tokatoka
Copy link
Contributor Author

looks good now

@aurelf
Copy link
Member

aurelf commented Nov 24, 2023

Excellent, thank you!

@aurelf aurelf merged commit 25a7565 into eurecom-s3:master Nov 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants