Sprint-2 registration-page layout#9
Merged
euguenia merged 3 commits intosprint-2_login-registration-mainfrom Aug 18, 2023
Merged
Sprint-2 registration-page layout#9euguenia merged 3 commits intosprint-2_login-registration-mainfrom
euguenia merged 3 commits intosprint-2_login-registration-mainfrom
Conversation
LikeKugi
approved these changes
Aug 15, 2023
Comment on lines
+10
to
+13
| console.log({ | ||
| email: data.get('email'), | ||
| password: data.get('password'), | ||
| }); |
Collaborator
There was a problem hiding this comment.
need to remove console.log
Comment on lines
+42
to
+45
| <Button size='small' variant='contained' sx={{px:4, mt: 2, backgroundColor: 'mediumaquamarine'}} onClick={()=>{ | ||
| const nextPage = page-1; | ||
| setPage(nextPage); | ||
| }}> |
Collaborator
There was a problem hiding this comment.
TODO: add logic to check if its the first page so the button should be disabled
Comment on lines
+52
to
+55
| <Button size='small' variant='contained' sx={{px:4, mt: 2, mx: 4, backgroundColor: 'mediumaquamarine'}} onClick={()=>{ | ||
| const nextPage = page+1; | ||
| setPage(nextPage); | ||
| }}> |
Collaborator
There was a problem hiding this comment.
the same thing: we'll need to add checking if its the last page and disable thwe button if its so
euguenia
approved these changes
Aug 18, 2023
| <Box | ||
| sx={{ | ||
| marginTop: 8, | ||
| display: 'flex', |
Owner
There was a problem hiding this comment.
styles should be moved to scss files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprint [sprint #2]
Task
Trello task link
Summary
Changelog
Screenshot