BAEL-9123: Added unit tests for elasticsearch wildcard service #18879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Torres <[email protected]>
theangrydev
requested changes
Oct 24, 2025
persistence-modules/spring-data-elasticsearch-2/src/main/resources/log4j2.properties
Outdated
Show resolved
Hide resolved
...2/src/test/java/com/baeldung/wildcardsearch/ElasticsearchWildcardServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
...2/src/test/java/com/baeldung/wildcardsearch/ElasticsearchWildcardServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
...2/src/test/java/com/baeldung/wildcardsearch/ElasticsearchWildcardServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
| <version>${spring-boot.version}</version> | ||
| </dependency> | ||
|
|
||
| <!-- https://mvnrepository.com/artifact/org.testcontainers/elasticsearch --> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <!-- https://mvnrepository.com/artifact/org.testcontainers/elasticsearch --> |
...-elasticsearch-2/src/main/java/com/baeldung/wildcardsearch/ElasticsearchWildcardService.java
Outdated
Show resolved
Hide resolved
Comment on lines
63
to
68
| // Wait for documents to be indexed | ||
| try { | ||
| Thread.sleep(1500); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| } |
Collaborator
There was a problem hiding this comment.
We can't use Thread.sleep - there should be a better way to specifically wait until the documents are indexed - as written this will either be a flaky test or waste CI build time
...search-2/src/test/java/com/baeldung/wildcardsearch/ElasticsearchWildcardServiceUnitTest.java
Show resolved
Hide resolved
Signed-off-by: Diego Torres <[email protected]>
Signed-off-by: Diego Torres <[email protected]>
theangrydev
reviewed
Nov 21, 2025
...2/src/test/java/com/baeldung/wildcardsearch/ElasticsearchWildcardServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
theangrydev
reviewed
Nov 21, 2025
| String email = emailObj != null ? emailObj.toString() | ||
| .toLowerCase() : ""; | ||
|
|
||
| assertTrue(name.contains("john") || email.contains("john"), "Expected 'john' in name or email"); |
Collaborator
There was a problem hiding this comment.
Missed this one (not using AssertJ like the other refactors)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.