Sqlite migrations fixed #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Any chance considering this patch for merging with the master branch? I understand that you are rewriting the whole library but I am using this in production and would be nice, in the meantime, if I could use the upstream version instead of tracking changes in my patched one. Not considering this patch could be an improvement for sqlite backend. Any feedback is appreciated. Bye! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
i was unable to use crane with sqlilte, during
migrationdatabase creation the library complains about an "alter table" which is not supported.The following patch try to fix that, it worked for me but i am unsure if this is a general solution (sorry for that, but i can not tests with other dbms).
Bye!
C.
PS: i found the unit test failed: fixed some; i will try to address the others ASAP.
PPS: Looks like all tests passed! :)