Feature/read from general stream #334
Conversation
| namespace utils { | ||
| bool readProtoMsgCountToStream(std::fstream* stream_in, uint32_t* message_count, | ||
| uint64_t* byte_offset); | ||
| bool readProtoMsgCountFromStream(std::istream* stream_in, |
There was a problem hiding this comment.
This is a naming correction that will break depending packages if they've implemented their own loading functions.
Obviously this function is reading from a stream, rather than to a stream.
There was a problem hiding this comment.
I think you should be able to rename this. AFAIK this should only be used deep in the internals of this stuff (note to self for future designs: hide functions like these :) )
There was a problem hiding this comment.
People implementing new layers, submap types etc have to call this function, which does seem a bit odd to me, as we've discussed before :). Imma merge and let's see if anyone complains.
| namespace utils { | ||
| bool readProtoMsgCountToStream(std::fstream* stream_in, uint32_t* message_count, | ||
| uint64_t* byte_offset); | ||
| bool readProtoMsgCountFromStream(std::istream* stream_in, |
There was a problem hiding this comment.
I think you should be able to rename this. AFAIK this should only be used deep in the internals of this stuff (note to self for future designs: hide functions like these :) )
I needed to read protobuf messages from a stream of data in memory (as opposed to in a file). I swapped loading function inputs from
fstream*toistream*. They were being implicitly cast to those types anyway, when passed to protobuf functions.I also corrected a naming typo... This is a breaking change for anyone depending on this function... But it was quite confusing.
on top of #332