Skip to content

Conversation

@eggerk
Copy link
Contributor

@eggerk eggerk commented Jan 9, 2018

No description provided.

@eggerk eggerk requested review from dymczykm, mfehr and schneith January 9, 2018 13:04
Copy link
Contributor

@mfehr mfehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfehr
Copy link
Contributor

mfehr commented Jan 11, 2018

You will need to remove benchmark_catkin from dependencies, can you open the PR for this as well, so we can merge them at the same time?

@eggerk
Copy link
Contributor Author

eggerk commented Jan 11, 2018

@mfehr
Copy link
Contributor

mfehr commented Jan 11, 2018

@eggerk great, I will force-merge them both, ok?

@eggerk
Copy link
Contributor Author

eggerk commented Jan 11, 2018

ok, good for me

@mfehr mfehr merged commit 15c9740 into devel/maplab_private Jan 11, 2018
@mfehr mfehr deleted the feature/benchmark_catkin branch January 11, 2018 13:12
@mfehr
Copy link
Contributor

mfehr commented Jan 11, 2018

@eggerk done, could you run a full build-test of maplab_private to verify everything is in order now?

@eggerk
Copy link
Contributor Author

eggerk commented Jan 11, 2018

@eggerk
Copy link
Contributor Author

eggerk commented Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants