-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu 20.04 and CI Dockerfiles #515
Conversation
Moved the creation of the cv2.namedWindow from the MonoCameraValidator constructor to the callback function. Otherwise, this caused the following error: QObject::startTimer: Timers cannot be started from another thread ... with the result that the image windows remained black and the node became stuck. Fixes ethz-asl#201 .
Not needed. And "from PIL import Image" compatible with Ubuntu 18.04 conflicts with "from sensor_msgs.msg import Image"
Docker instructions to be added to the wiki: First make sure that you have install docker on your system using the official Docker Get Docker guide.
Then after building we can first download an example dataset and then perform following to calibrate.
We can now mount the data folder in the container
|
…ver camera calibration debug windows
This is a PR of the ori-drs/kalibr repo which has fixes for 20.04 and python3. As mentioned in #405 (comment) I forked and am willing to handle review comments to make this mergeable. I have additionally added Docker files and a CI github action to build the Docker files to ensure that the codebase builds on all platforms (ubuntu 16.04 kinetic, 18.04 melodic, 20.04 noetic). There were some modifications I needed to perform from the ori-drs repo to ensure that everything still built with python2.
I have tested performing camera calibration, and camera to IMU calibration with the sample datasets. One can see the github action CI builds here. The goldbattle/kalibr Readme has instructions on how to build and use the docker.
A short summary of changes:
The readme will likely need some small changes along with the wiki (or just add example build instructions to the readme).