Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Flutter listeners and callHandlers in the Sample App for native app communication #5597

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Dec 11, 2024

Description Of Changes

Adds a "FidesUpdated" listener which in turn triggers a "FidesUpdated" event in the Flutter apps which have these pages open in a webveiw.

Code Changes

  • Some minor renaming and inconsistency updates
  • Upgrade react-select for the Cookie House region selector
  • Add "FidesUpdated" listener/trigger on both the Cookie House webpage and the Embedded Consent.

Steps to Confirm

NOTE: These updates are completely reliant on the Flutter Native App to be running in order to work. Testing is not feasible for this PR alone, so a thorough code review will have to suffice.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2024 9:50pm

@gilluminate gilluminate force-pushed the gill/HJ-239/sample-native-app-poc branch from 838a11a to 903e0f5 Compare December 11, 2024 21:41
@gilluminate gilluminate force-pushed the gill/HJ-239/sample-native-app-poc branch from 903e0f5 to 8fd228e Compare December 11, 2024 21:45
@gilluminate gilluminate requested a review from jpople December 11, 2024 21:50
Copy link

cypress bot commented Dec 11, 2024

fides    Run #11454

Run Properties:  status check passed Passed #11454  •  git commit 4984ab0668 ℹ️: Merge 1ddcfff46859e1935a9b1f6b4d105a30fee7527d into 9bbab10f1de89f652ac95e41e754...
Project fides
Branch Review refs/pull/5597/merge
Run status status check passed Passed #11454
Run duration 00m 50s
Commit git commit 4984ab0668 ℹ️: Merge 1ddcfff46859e1935a9b1f6b4d105a30fee7527d into 9bbab10f1de89f652ac95e41e754...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@gilluminate gilluminate merged commit 776cbcb into main Dec 12, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/HJ-239/sample-native-app-poc branch December 12, 2024 15:24
Copy link

cypress bot commented Dec 12, 2024

fides    Run #11461

Run Properties:  status check passed Passed #11461  •  git commit 776cbcbf15: Set up Flutter listeners and callHandlers in the Sample App for native app commu...
Project fides
Branch Review main
Run status status check passed Passed #11461
Run duration 00m 40s
Commit git commit 776cbcbf15: Set up Flutter listeners and callHandlers in the Sample App for native app commu...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants