Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing quickstart #5585

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Fixing quickstart #5585

merged 4 commits into from
Dec 10, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 9, 2024

Closes LA-206

Description Of Changes

Adding MonitorConfig import to postgres_setup.py to fix data seeding

Steps to Confirm

  1. Run nox -s quickstart and go through the steps, you should see the access results JSON at the end

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:29pm

@galvana galvana marked this pull request as ready for review December 9, 2024 22:56
Comment on lines +25 to +26
- SaaS integrations using `oauth_client_credentials` now properly update their access token when editing the secrets [#5548](https://github.com/ethyca/fides/pull/5548)
- Saas integrations using `oauth_client_credentials` now properly refresh their access token when the current token expires [#5569](https://github.com/ethyca/fides/pull/5569)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding missing PR links

Copy link

cypress bot commented Dec 9, 2024

fides    Run #11396

Run Properties:  status check passed Passed #11396  •  git commit 320e77a139 ℹ️: Merge ccfb708081d0ef4b3624f2ceb924a9728a673805 into bef6e27a0378d082dd550ac97847...
Project fides
Branch Review refs/pull/5585/merge
Run status status check passed Passed #11396
Run duration 00m 37s
Commit git commit 320e77a139 ℹ️: Merge ccfb708081d0ef4b3624f2ceb924a9728a673805 into bef6e27a0378d082dd550ac97847...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@galvana galvana merged commit dab4de4 into main Dec 10, 2024
34 of 37 checks passed
@galvana galvana deleted the LA-206-fix-quickstart branch December 10, 2024 16:11
Copy link

cypress bot commented Dec 10, 2024

fides    Run #11401

Run Properties:  status check passed Passed #11401  •  git commit dab4de4496: Fixing quickstart (#5585)
Project fides
Branch Review main
Run status status check passed Passed #11401
Run duration 00m 55s
Commit git commit dab4de4496: Fixing quickstart (#5585)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

andres-torres-marroquin added a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Andres Torres <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants