Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-106: Integrate erasure request for BigQuery Enterprise DSR Testing Initiative #5554

Merged
merged 9 commits into from
Dec 5, 2024
Merged

LA-106: Integrate erasure request for BigQuery Enterprise DSR Testing Initiative #5554

merged 9 commits into from
Dec 5, 2024

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Dec 3, 2024 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/LA-106

Description Of Changes

Writes erasure test against Bigquery enterprise

Code Changes

  • Write new test, incl data generation, and associated yaml updates

Steps to Confirm

  1. Ensure pipeline passes using run unsafe ci checks Github label
  2. To test manually, ensure you have bigquery enterprise creds set up in your env, then run nox -s dev -- shell, then pytest tests/ops/service/privacy_request/test_bigquery_enterprise_privacy_request.py::test_create_and_process_erasure_request_bigquery -s

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 5:44pm

@eastandwestwind eastandwestwind added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Dec 3, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 3, 2024 •
edited
Loading

fides    Run #11264

Run Properties:  status check passed Passed #11264  •  git commit 4d38d00f3d ℹ️: Merge de0fdaba7216135fe0de2ca0c4adaae2a3f30fd9 into 966a0e32794c458e669035c13126...
Project fides
Branch Review refs/pull/5554/merge
Run status status check passed Passed #11264
Run duration 00m 39s
Commit git commit 4d38d00f3d ℹ️: Merge de0fdaba7216135fe0de2ca0c4adaae2a3f30fd9 into 966a0e32794c458e669035c13126...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@galvana galvana self-requested a review December 3, 2024 23:51
galvana
galvana approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! I had to rename the env var in 1pass to BIGQUERY_ENTERPRISE_KEYFILE_CREDS for this to work, but all good other than that

tests/fixtures/bigquery_fixtures.py Show resolved Hide resolved
@eastandwestwind eastandwestwind merged commit 1415108 into main Dec 5, 2024
38 of 40 checks passed
@eastandwestwind eastandwestwind deleted the LA-106 branch December 5, 2024 15:01
@cypress Cypress
Copy link

cypress bot commented Dec 5, 2024

fides    Run #11285

Run Properties:  status check passed Passed #11285  •  git commit 141510802f: LA-106: Integrate erasure request for BigQuery Enterprise DSR Testing Initiative...
Project fides
Branch Review main
Run status status check passed Passed #11285
Run duration 00m 36s
Commit git commit 141510802f: LA-106: Integrate erasure request for BigQuery Enterprise DSR Testing Initiative...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024
@eastandwestwind @andres-torres-marroquin
LA-106: Integrate erasure request for BigQuery Enterprise DSR Testing…
9585243 
… Initiative (#5554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastandwestwind @galvana