Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-250 - Address PyPi deprecation warnings #5550

Merged
merged 2 commits into from
Dec 11, 2024
Merged

HJ-250 - Address PyPi deprecation warnings #5550

merged 2 commits into from
Dec 11, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #HJ-250

Description Of Changes

Address PyPi deprecation warnings on Pypi

Code Changes

  • Updated name on setup.py

Steps to Confirm

  1. While being on this branch, nox -s "tag(push)" you should not receive an email about the deprecation warning.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:44pm

@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024 •
edited
Loading

fides    Run #11429

Run Properties:  status check failed Failed #11429  •  git commit 2a76fc004b ℹ️: Merge d04795771d4861e6877f426f39b2b78426916f02 into e6609fa45da1b211680902f3811c...
Project fides
Branch Review refs/pull/5550/merge
Run status status check failed Failed #11429
Run duration 01m 05s
Commit git commit 2a76fc004b ℹ️: Merge d04795771d4861e6877f426f39b2b78426916f02 into e6609fa45da1b211680902f3811c...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

erosselli
erosselli reviewed Dec 2, 2024
View reviewed changes
setup.py
name="ethyca-fides",
name="ethyca_fides",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know if this change will affect anything in how fides is installed or imported?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andres-torres-marroquin one thing to test specifically may be that fidesplus can build with the package that's published from this branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andres-torres-marroquin one thing to test specifically may be that fidesplus can build with the package that's published from this branch

adamsachs
adamsachs approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andres-torres-marroquin based on your testing, let's go ahead and get this merged (and the further it is away from the release cycle, the more time it gives us to iron out any kinks 👍 ).

before merging though, can you address the git history? this PR shouldn't be showing 26 commits...

@andres-torres-marroquin andres-torres-marroquin force-pushed the andres/HJ-250 branch 2 times, most recently from 7623f50 to d047957 Compare December 11, 2024 15:40
@andres-torres-marroquin andres-torres-marroquin merged commit 05e0a94 into main Dec 11, 2024
13 of 14 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-250 branch December 11, 2024 15:41
@cypress Cypress
Copy link

cypress bot commented Dec 11, 2024

fides    Run #11428

Run Properties:  status check failed Failed #11428  •  git commit 05e0a947de: HJ-250 - Address PyPi deprecation warnings (#5550)
Project fides
Branch Review main
Run status status check failed Failed #11428
Run duration 01m 06s
Commit git commit 05e0a947de: HJ-250 - Address PyPi deprecation warnings (#5550)
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 3
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosselli erosselli erosselli left review comments

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andres-torres-marroquin @adamsachs @erosselli