Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Improvements: EU Formatting #3611

Closed
pattisdr opened this issue Jun 19, 2023 · 1 comment · Fixed by #3630
Closed

Location Improvements: EU Formatting #3611

pattisdr opened this issue Jun 19, 2023 · 1 comment · Fixed by #3630
Assignees

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Jun 19, 2023

Is your feature request related to a specific problem?

We have a mixture of formats in our PrivacyNoticeRegions. For example, in the us, it is country_state (us_ca) but in the EU, it is countrygroup_country (eu_fr). As a first round of location improvements, make all eu-prefixed countries just be their country prefix (fr). Allow filtering on either region or country.

Describe the solution you'd like

  • Switch all eu prefixed countries to just be the country prefix
  • Keep API query params the same: GET /privacy_experience?region=fr_idg, or ?region=fr.
    • Add new filtering requirements: first prioritize matching "fr_idg" - if this doesn't exist, then search for any matching "fr".
    • In other words, allow the API to fall back to a more generic country match if the region match isn't found.
  • We need a data migration for any existing notices, notice histories, and experiences with these region codes.
  • Update out of the box notices to have new country codes

Further context: https://ethyca.slack.com/archives/C04S7K0T2V7/p1687204241866249

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@pattisdr pattisdr changed the title Location Improvements Location Improvements: EU Formatting Jun 19, 2023
@pattisdr pattisdr self-assigned this Jun 19, 2023
pattisdr added a commit that referenced this issue Jun 28, 2023
Update eu regions to drop the eu prefix, so everything is structured "country_region" or just "country". The eu was originally structured like "countrygroup_country".

On a related note, drop back to filtering experiences by country if their specific detected region isn't found.
@Roger-Ethyca
Copy link
Contributor

moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants